Skip to content

fix: correct digest progress semantics#45

Merged
Moskize91 merged 1 commit into
mainfrom
fix/digest-progress-phase-separation
May 6, 2026
Merged

fix: correct digest progress semantics#45
Moskize91 merged 1 commit into
mainfrom
fix/digest-progress-phase-separation

Conversation

@Moskize91

Copy link
Copy Markdown
Contributor

Summary

  • correct digest progress so it advances only when a serial finishes its second stage
  • keep serial progress tied to first-stage fragment processing
  • bump the package version to 0.1.7

Testing

  • pnpm run lint:fix
  • pnpm test -- --runInBand test/common/progress-tracker.test.ts test/cli/progress.test.ts test/facade/digest.test.ts

@coderabbitai

coderabbitai Bot commented May 6, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 09da1a89-0977-4768-ab7d-43bc6034c325

📥 Commits

Reviewing files that changed from the base of the PR and between 053d76a and a8834b4.

📒 Files selected for processing (3)
  • package.json
  • src/progress/tracker.ts
  • test/common/progress-tracker.test.ts

Summary by CodeRabbit

  • Chores

    • Bumped package version to 0.1.7.
    • Optimized progress tracking implementation.
  • Tests

    • Updated progress tracker tests to reflect revised signaling behavior.

Walkthrough

Version bumped to 0.1.7. The DigestProgressTracker's progress tracking flow was refactored to centralize per-serial state management in the completeSerial method, which now accepts an input object containing the serial ID and word count. The emitSerialProgress method was simplified to only emit events without state mutations. SerialProgressTracker.complete was updated to pass the required object format. Test expectations were adjusted to reflect that digest progress is now emitted after serial completion rather than during fragment work, and a new test was added to verify digest progress remains zero during active serial work.

Possibly related PRs

  • oomol-lab/spinedigest#39: Modifies DigestProgressTracker's per-serial progress handling with tied changes to completeSerial/emitSerialProgress behavior and per-serial state management.
  • oomol-lab/spinedigest#31: Modifies progress-tracking behavior in src/progress/tracker.ts with changes to when serial progress is emitted and SerialProgressTracker.complete/completeSerial interactions.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format <type>(<scope>): <subject> and accurately describes the main change of correcting digest progress semantics.
Description check ✅ Passed The description clearly relates to the changeset, outlining the progress tracking improvements and version bump that match the file modifications.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/digest-progress-phase-separation

Comment @coderabbitai help to get the list of available commands and usage tips.

@Moskize91 Moskize91 merged commit 327ed39 into main May 6, 2026
3 checks passed
@Moskize91 Moskize91 deleted the fix/digest-progress-phase-separation branch May 6, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant