-
Notifications
You must be signed in to change notification settings - Fork 82
chore(node/rpc): Refactor p2p rpc #1633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3e3b385
to
b3a1b81
Compare
b3a1b81
to
d0463f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to see these types split into separate modules in the future instead of having a large 376 line file. Not a blocker for this PR since I know it was ported over. Bad practice set by me 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this
d0463f7
to
44cbfc6
Compare
Description
Refactoring PR that tidies up the RPC implementation of kona-p2p in preparation of the implementation of the node rpc api.
Please note that I had to slightly change the feature-gating of the
Metrics
struct in thep2p
crate to allow access to theMetrics
struct insidenet
without having to feature-gate it's usage every timeProgress towards #1634