Skip to content

chore(node/rpc): Refactor p2p rpc #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theochap
Copy link
Member

@theochap theochap commented May 2, 2025

Description

Refactoring PR that tidies up the RPC implementation of kona-p2p in preparation of the implementation of the node rpc api.

Please note that I had to slightly change the feature-gating of the Metrics struct in the p2p crate to allow access to the Metrics struct inside net without having to feature-gate it's usage every time

Progress towards #1634

@theochap theochap added K-chore Kind: chore A-node Area: node crates A-rpc Area: rpc A-p2p Area: p2p labels May 2, 2025
@theochap theochap requested review from clabby, refcell and emhane as code owners May 2, 2025 15:59
@theochap theochap moved this to In Review in Project Tracking May 2, 2025
Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 59.8%. Comparing base (1cb1ce2) to head (44cbfc6).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/node/p2p/src/rpc/types.rs 0.0% 29 Missing ⚠️
crates/node/p2p/src/rpc/request.rs 0.0% 4 Missing ⚠️
crates/node/p2p/src/net/builder.rs 0.0% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1cb1ce2) and HEAD (44cbfc6). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (1cb1ce2) HEAD (44cbfc6)
10 4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theochap theochap marked this pull request as draft May 2, 2025 16:16
@theochap theochap force-pushed the theo/implement-node-rpc-api branch from 3e3b385 to b3a1b81 Compare May 2, 2025 16:34
@theochap theochap marked this pull request as ready for review May 2, 2025 16:35
@theochap theochap force-pushed the theo/implement-node-rpc-api branch from b3a1b81 to d0463f7 Compare May 2, 2025 16:45
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see these types split into separate modules in the future instead of having a large 376 line file. Not a blocker for this PR since I know it was ported over. Bad practice set by me 😅

Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this

@theochap theochap force-pushed the theo/implement-node-rpc-api branch from d0463f7 to 44cbfc6 Compare May 2, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-node Area: node crates A-p2p Area: p2p A-rpc Area: rpc K-chore Kind: chore
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants