Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

Conversation

@Himess
Copy link
Contributor

@Himess Himess commented Dec 13, 2025

Updates outdated docs after actor system refactoring. Fixed NodeActor trait examples, removed RollupNodeService references, and fixed a broken GitHub link.

Closes #3137

Update documentation to match current codebase after actor system refactoring:

- Update NodeActor trait example to use simplified trait signature
  (Error + StartData types instead of InboundData/OutboundData/State)
- Replace outdated RollupNodeService trait example with RollupNodeBuilder usage
- Update design/intro.mdx to reference RollupNode and RollupNodeBuilder
  instead of the removed RollupNodeService trait
- Fix broken GitHub links to point to current file locations
- Update terminology (remove "subclassing" which doesn't apply to Rust)

Closes op-rs#3137
@Himess Himess marked this pull request as draft December 13, 2025 16:32
…ntation

- Update NodeActor trait in engine.mdx to use simplified signature (Error, StartData)
- Remove outdated RollupNodeService trait reference in sequencer.mdx
- Replace InboundData/OutboundData/Builder with current StartData pattern
@Himess Himess marked this pull request as ready for review December 13, 2025 16:39
@codecov
Copy link

codecov bot commented Dec 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.9%. Comparing base (cdb9be2) to head (ec808a0).
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (cdb9be2) and HEAD (ec808a0). Click for more details.

HEAD has 22 uploads less than BASE
Flag BASE (cdb9be2) HEAD (ec808a0)
proof 11 0
e2e 10 0
unit 2 1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

This pull request has been automatically marked as stale because it has been inactive for 3 weeks.
It will be closed in 1 week if no further activity occurs.
If you believe this PR should remain open, please add the M-prevent-stale label or leave a comment.

@github-actions github-actions bot added M-stale and removed M-stale labels Jan 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(node): update documentation on the actor design

1 participant