-
Notifications
You must be signed in to change notification settings - Fork 217
Add polite guard #1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add polite guard #1223
Conversation
3510bf5 to
c561c25
Compare
3b6569b to
be910a0
Compare
be910a0 to
6b591e7
Compare
|
Hi @Ankur-singh , please check the failure of Also, please add a test scirpt here and follow the naming schema. Thanks! |
6b591e7 to
6114a76
Compare
c37de4b to
db947de
Compare
|
Hi @letonghan, thank you for your help. I have made the requested changes. Fingers crossed, all checks should pass. |
c12e9f3 to
72efdf2
Compare
|
Hi @letonghan can you please help me with the failed checks? I see that docker containers is created but the curl request fails. Other two services ( Sorry about polluting the PR. Is there a way to run these workflows locally? I'll clear the next commit. |
72efdf2 to
d4fa6e5
Compare
|
Are you still working on this? The environments variables are not set.
|
|
Yes, still working on it. Sorry for the delay though. |
d4fa6e5 to
b1b1849
Compare
|
@xiguiw looks like ENV VARs were not the problem. Checked the log for other services (successful) and saw the same warning messages. Tried to run PS: @letonghan I believe, we should add similar checks for other services as well. Update: Getting the following error, https://github.com/opea-project/GenAIComps/actions/runs/13624534401/job/38079510858?pr=1223#step:5:938 Are these tests executed in parallel? Does each service need to have an unique port number? |
b1b1849 to
4267539
Compare
4267539 to
87dc4f1
Compare
|
Remind |
bd25a5a to
792993e
Compare
Signed-off-by: Ankur-singh <[email protected]> Signed-off-by: Ankur Singh <[email protected]>
Signed-off-by: Ankur-singh <[email protected]> Signed-off-by: Ankur Singh <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Ankur-singh <[email protected]> Signed-off-by: Ankur Singh <[email protected]>
Signed-off-by: Ankur-singh <[email protected]> Signed-off-by: Ankur Singh <[email protected]>
Signed-off-by: Ankur-singh <[email protected]> Signed-off-by: Ankur Singh <[email protected]>
Signed-off-by: Ankur Singh <[email protected]>
d2cb957 to
09b44f9
Compare
| set -x | ||
|
|
||
| WORKPATH=$(dirname "$PWD") | ||
| ip_address=$(hostname -I | awk '{print $1}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ip_address" unreferenced
|
Hi @Ankur-singh could you please check the CI failures? Thanks. |
Description
Integrates Intel's Polite Guard model as one of the guardrail component/microservice.
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
No new dependency
Tests
Describe the tests that you ran to verify your changes.
I successfully tested the microservice by running it both as Python script and as Docker microservice. Both methods worked as expected, and I was able to verify the functionality of the component with different inputs.