Skip to content

Conversation

@ZePan110
Copy link
Collaborator

@ZePan110 ZePan110 commented Apr 28, 2025

Description

Provide ARCH option for lvm-video-llama image build.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

https://github.com/opea-project/GenAIComps/actions/runs/14722643512/job/41319172649

eero-t
eero-t previously requested changes Apr 28, 2025
Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO better than removing the packages, is failing the build if there are such dependencies. Nvidia builds of components like PyTorch are likely to fail on init after their Nvidia deps are gone.

@joshuayao joshuayao added the bug Something isn't working label Apr 29, 2025
@joshuayao joshuayao added this to OPEA Apr 29, 2025
@joshuayao joshuayao moved this to In review in OPEA Apr 29, 2025
@joshuayao joshuayao added this to the v1.3 milestone Apr 29, 2025
@joshuayao joshuayao added the r1.3 label Apr 29, 2025
Signed-off-by: ZePan110 <[email protected]>
@chensuyue chensuyue changed the title Delete NV related package Provide ARCH option for lvm-video-llama image build Apr 29, 2025
@chensuyue chensuyue dismissed eero-t’s stale review April 29, 2025 03:54

comments resolved.

@chensuyue chensuyue merged commit a40bc4a into main Apr 29, 2025
26 checks passed
@chensuyue chensuyue deleted the rm-nv branch April 29, 2025 03:54
@github-project-automation github-project-automation bot moved this from In review to Done in OPEA Apr 29, 2025
chensuyue pushed a commit that referenced this pull request Apr 29, 2025
madison-evans pushed a commit to SAPD-Intel/GenAIComps that referenced this pull request May 12, 2025
alexsin368 pushed a commit to alexsin368/GenAIComps that referenced this pull request May 15, 2025
yinghu5 added a commit that referenced this pull request May 16, 2025
* add support for remote server

Signed-off-by: alexsin368 <[email protected]>

* add steps to enable remote server

Signed-off-by: alexsin368 <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* remove use_remote_service

Signed-off-by: alexsin368 <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add OpenAI models instructions, fix format of commands

Signed-off-by: alexsin368 <[email protected]>

* simplify ChatOpenAI instantiation

Signed-off-by: alexsin368 <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert "simplify ChatOpenAI instantiation"

This reverts commit b7c4acf.

* add back check and logic for llm_engine, set openai_key argument

Signed-off-by: alexsin368 <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Provide ARCH option for lvm-video-llama image build (#1630)

Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>

* Add sglang microservice for supporting llama4 model (#1640)

Signed-off-by: Ye, Xinyu <[email protected]>
Co-authored-by: Lv,Liang1 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>

* Remove invalid codeowner. (#1642)

Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>

* add support for remote server

Signed-off-by: alexsin368 <[email protected]>

* add steps to enable remote server

Signed-off-by: alexsin368 <[email protected]>

* remove use_remote_service

Signed-off-by: alexsin368 <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: alexsin368 <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: alexsin368 <[email protected]>

* bug fix for chunk_size and overlap cause error in dataprep ingestion (#1643)

* bug fix for dataingest url

Signed-off-by: Mustafa <[email protected]>

* add validation function

Signed-off-by: Mustafa <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* validation update

Signed-off-by: Mustafa <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update validation function

Signed-off-by: Mustafa <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mustafa <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: alexsin368 <[email protected]>

* MariaDB Vector integrations for retriever & dataprep services (#1645)

* Add MariaDB Vector third-party service

MariaDB Vector was introduced since MariaDB Server 11.7

Signed-off-by: Razvan-Liviu Varzaru <[email protected]>

* Add retriever MariaDB Vector integration

Signed-off-by: Razvan-Liviu Varzaru <[email protected]>

* Add dataprep MariaDB Vector integration

Signed-off-by: Razvan-Liviu Varzaru <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix CI failures

- md5 is used for the primary key not as a security hash
- fixed mariadb readme headers

Signed-off-by: Razvan-Liviu Varzaru <[email protected]>

---------

Signed-off-by: Razvan-Liviu Varzaru <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: alexsin368 <[email protected]>

* update PR reviewers (#1651)

Signed-off-by: chensuyue <[email protected]>
Signed-off-by: alexsin368 <[email protected]>

* Expand test matrix, find all tests use 3rd party Dockerfiles (#1676)

* Expand test matrix, find all tests use 3rd party Dockerfiles

Signed-off-by: chensuyue <[email protected]>
Signed-off-by: alexsin368 <[email protected]>

* fix the typo of README.md Comp (#1679)

Update README.md for first entry of OPEA

Signed-off-by: alexsin368 <[email protected]>

* Fix request handle timeout issue (#1687)

Signed-off-by: lvliang-intel <[email protected]>
Signed-off-by: alexsin368 <[email protected]>

* FEAT: Enable OPEA microservices to start as MCP servers (#1635)

Signed-off-by: alexsin368 <[email protected]>

* Fix huggingface_hub API upgrade issue (#1691)

* Fix huggingfacehub API upgrade issue

Signed-off-by: lvliang-intel <[email protected]>
Signed-off-by: alexsin368 <[email protected]>

* add OpenAI models instructions, fix format of commands

Signed-off-by: alexsin368 <[email protected]>

* Fix dataprep opensearch ingest issue (#1697)

Signed-off-by: lvliang-intel <[email protected]>
Signed-off-by: alexsin368 <[email protected]>

* Fix embedding issue with ArangoDB due to deprecated HuggingFace API (#1694)

Signed-off-by: lvliang-intel <[email protected]>
Signed-off-by: alexsin368 <[email protected]>

* simplify ChatOpenAI instantiation

Signed-off-by: alexsin368 <[email protected]>

* Revert "simplify ChatOpenAI instantiation"

This reverts commit b7c4acf.

Signed-off-by: alexsin368 <[email protected]>

* add back check and logic for llm_engine, set openai_key argument

Signed-off-by: alexsin368 <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: Ye, Xinyu <[email protected]>
Signed-off-by: Mustafa <[email protected]>
Signed-off-by: Razvan-Liviu Varzaru <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: lvliang-intel <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ying Hu <[email protected]>
Co-authored-by: ZePan110 <[email protected]>
Co-authored-by: Liang Lv <[email protected]>
Co-authored-by: Mustafa <[email protected]>
Co-authored-by: Razvan Liviu Varzaru <[email protected]>
Co-authored-by: chen, suyue <[email protected]>
Co-authored-by: Spycsh <[email protected]>
WenjiaoYue pushed a commit that referenced this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working r1.3

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants