Skip to content

Conversation

@qgao007
Copy link
Collaborator

@qgao007 qgao007 commented Oct 21, 2024

Description

To enable bash script to be path-independent using $0 to address errors when following our README because of absolute path issues.

bash ${OPEA_GENAICOMPS_ROOT}/comps/llms/text-generation/vllm/langchain/dependency/build_docker_vllm.sh cpu
ERROR: failed to solve: failed to read dockerfile: open Dockerfile.intel_hpu: no such file or directory

Issues

'n/a'

Type of change

List the type of change like below. Please delete options that are not relevant.

  • [X ] Bug fix (non-breaking change which fixes an issue)

Dependencies

None.

Tests

Tested bash script in different folder and no issues after enabling path-independence.

…failed to solve: failed to read dockerfile: open Dockerfile.intel_hpu: no such file or director when following README

Signed-off-by: Qun Gao <[email protected]>
@qgao007 qgao007 requested review from ashahba and chensuyue October 21, 2024 15:54
@qgao007 qgao007 self-assigned this Oct 22, 2024
@ZePan110
Copy link
Collaborator

ZePan110 commented Nov 4, 2024

@qgao007 Please fix CI issue

Copy link
Collaborator

@ashahba ashahba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashahba ashahba merged commit 9a50131 into main Nov 8, 2024
12 checks passed
@ashahba ashahba deleted the qg/hallu branch November 8, 2024 20:04
madison-evans pushed a commit to SAPD-Intel/GenAIComps that referenced this pull request May 12, 2025
…failed to solve: failed to read dockerfile: open Dockerfile.intel_hpu: no such file or director when following README (opea-project#808)

Signed-off-by: Qun Gao <[email protected]>
Co-authored-by: ZePan110 <[email protected]>
Co-authored-by: Abolfazl Shahbazi <[email protected]>
WenjiaoYue pushed a commit that referenced this pull request Jul 7, 2025
Signed-off-by: lvliang-intel <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants