Fix weekly oneclick issues #2193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues in the weekly one-click testing workflow by adding a missing checkout step and reorganizing dependency installation. The changes address workflow execution problems by ensuring the repository code is available before running matrix generation and installing system dependencies earlier in the process.
- Added missing checkout step to the weekly one-click test workflow
- Moved dependency installation to occur before parameter retrieval
- Removed duplicate dependency installation from later in the workflow
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/weekly-one-click-test.yml |
Added checkout step to ensure repository code is available for matrix generation |
.github/workflows/_run-one-click.yml |
Moved dependency installation earlier and removed duplicate installation commands |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
for more information, see https://pre-commit.ci
Collaborator
Author
chensuyue
approved these changes
Aug 14, 2025
yao531441
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix weekly oneclick issues
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.