Skip to content

Conversation

@yao531441
Copy link
Collaborator

Description

Dynamically load defaults by executing set_env.sh on one click deploy scripts.

Issues

CI test fail cases
https://github.com/opea-project/GenAIExamples/actions/runs/17874502052/job/51091036509

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

n/a

Tests

CI

Copilot AI review requested due to automatic review settings September 24, 2025 08:26
@github-actions
Copy link

github-actions bot commented Sep 24, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR dynamically loads default values for interactive parameters by executing shell scripts instead of relying on hardcoded defaults. The change addresses CI test failures by sourcing environment variables from set_env.sh scripts during deployment configuration.

  • Replaces static text parsing with shell script execution for robust variable extraction
  • Removes hardcoded default values from configuration and loads them dynamically from scripts
  • Adds --quiet-pull flag to docker-compose commands

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
one_click_deploy/core/utils.py Replaces regex-based text parsing with shell script execution for environment variable extraction
one_click_deploy/core/deployer.py Integrates dynamic default loading and adds quiet-pull flag to docker-compose
one_click_deploy/core/config.py Removes hardcoded default values from interactive parameter configurations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ZePan110 ZePan110 self-requested a review as a code owner September 25, 2025 02:55
@ZePan110 ZePan110 merged commit ba6ff93 into main Sep 25, 2025
18 checks passed
@ZePan110 ZePan110 deleted the yao531441/one_click_fix branch September 25, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants