Conversation
This is to prevent the many problems because colors can be either Strings, Symbols or RGBA, depending on the context.
Some tests that check if the factors are withing sampling bounds stopped working after reactive intervention strategies were introduced. That's because the sampling method sometimes changes their values to zero even when the lower sampling bound is greater than zero. In those cases, I am not testing these parameters.
Member
Author
Collaborator
|
I suggest adding a prefix to the "TEST" flag as these are environment variables and can be set by any program. Leads to confusion/conflict. Other env flags start with "ADRIA_" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RGBA{Float32}andRGBA{Float64})test/data_loading.jl. An error was occurring there, likely caused by unclosed file handles between calls.test/sampling.jlafter introduction of reactive intervention strategy parameters. The sampling method sometimes changes the values of these parameters to zero, even when though some of them have lower sampling bound greater than zero. In those cases, these parameters are not being tested.