Align shared form control heights#68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Native selects, text inputs, and buttons used different intrinsic line-height calculations. In the repository toolbar this produced 48.3–48.8px fields beside 44px buttons, leaving the button tops visibly lower despite shared bottom alignment.
Test plan
pnpm lint(passes with 3 existing Fast Refresh warnings)pnpm typecheckpnpm --filter @opensymbols/site test(65 tests)pnpm test(site/server, PostgreSQL integration, and 26 legacy tests)pnpm builddocker compose config --quietgit diff --checkTrue browser-level 400% zoom and forced-colors rendering remain manual reviewer checks; the equivalent narrow-width reflow was verified at 320px.
Scope and risk
This changes only shared control sizing. Component interfaces, form behavior, responsive breakpoints, textareas, and PR #54 are unchanged.
Closes #67