Skip to content

docs: add ICAR link for Fortran implementation of MPDATA#680

Open
slayoo wants to merge 2 commits intomainfrom
slayoo-patch-17
Open

docs: add ICAR link for Fortran implementation of MPDATA#680
slayoo wants to merge 2 commits intomainfrom
slayoo-patch-17

Conversation

@slayoo
Copy link
Copy Markdown
Member

@slayoo slayoo commented Apr 12, 2026

No description provided.

@slayoo slayoo requested a review from Griger5 April 12, 2026 10:59
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.93%. Comparing base (2e8a4d2) to head (5f73d2e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #680   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files          40       40           
  Lines        1754     1754           
=======================================
  Hits         1630     1630           
  Misses        124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@slayoo
Copy link
Copy Markdown
Member Author

slayoo commented Apr 13, 2026

Hmm... we have a failure here, which is unrelated to the change, but worth addressing:

E   UserWarning: h5py is running against HDF5 2.1.1 when it was built against 2.0.0, this may cause problems

It's a bit surprising given that we are compiling h5py ourselves on CI!

HDF5_MPI="ON" CC=mpicc pip install --no-binary=h5py h5py==3.16.0

but perhaps it was cached!
trying to regenerate cache by adding a dummy change the setup.py...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants