Skip to content

bump SUNDIALS submodule to v6.7.0 (blocked by CAMP not supporting SUNDIALS >= 6)#343

Open
slayoo wants to merge 3 commits into
open-atmos:mainfrom
slayoo:sundials_bump
Open

bump SUNDIALS submodule to v6.7.0 (blocked by CAMP not supporting SUNDIALS >= 6)#343
slayoo wants to merge 3 commits into
open-atmos:mainfrom
slayoo:sundials_bump

Conversation

@slayoo

@slayoo slayoo commented Feb 27, 2024

Copy link
Copy Markdown
Member

No description provided.

@slayoo slayoo changed the title bump SUNDIALS submodule to v6.7.0 bump SUNDIALS submodule to v6.7.0 (blocked by CAMP not supporting SUNDIALS >= 6) Feb 27, 2024
@slayoo

slayoo commented Feb 27, 2024

Copy link
Copy Markdown
Member Author

this fails with:

      /home/runner/work/PyPartMC/PyPartMC/gitmodules/camp/src/camp_solver.c:145:11: error: too few arguments to function ‘N_VNew_Serial’
        145 |   sd->y = N_VNew_Serial(n_dep_var * n_cells);
            |           ^~~~~~~~~~~~~

We need to update SUNDIALS calls within CAMP as it was done by @alhirzel for PartMC in compdyn/partmc@db9d8dc

@slayoo slayoo mentioned this pull request Apr 2, 2024
Closed
@github-actions

github-actions Bot commented Mar 14, 2025

Copy link
Copy Markdown

Stale pull request message

@github-actions

github-actions Bot commented Nov 1, 2025

Copy link
Copy Markdown

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

no-activity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@slayoo