ci: split chocolatey/winget out of release pipeline - #109
Merged
Conversation
Mirrors atlassian-cli's pattern: keep the release workflow focused on goreleaser/snap/linux-packages so a flaky Microsoft-hosted publish step (wingetcreate fork-sync, choco push) can't gate the actual binary and Homebrew artifacts. The standalone chocolatey-publish.yml and winget-publish.yml are workflow_dispatch-only and run manually after a release lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chocolateyandwingetjobs fromrelease.yml. Both already exist as standaloneworkflow_dispatch-only workflows (chocolatey-publish.yml,winget-publish.yml).open-cli-collective/atlassian-clirelease-{cfl,jtk}.yml) so flaky Microsoft-hosted services don't gate the actual binary/Homebrew artifacts.Why
The v1.0.40 release exposed this: the embedded
wingetjob failed on wingetcreate's fork-sync error while the embeddedchocolateyjob ran fine — but both were marked `continue-on-error: true`, so they'd silently fail without anyone noticing. Splitting them out makes the failure mode loud and the retry path obvious (`gh workflow run winget-publish.yml -f version=X.Y.Z` after manually syncing the fork).Test plan
gh workflow run chocolatey-publish.yml -f version=<X>andgh workflow run winget-publish.yml -f version=<X>continue to work for manual publishes