Skip to content

gro: remove per-command --json (BREAKING) [#144] #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rianjs merged 5 commits into from
May 28, 2026
Merged

gro: remove per-command --json (BREAKING) [#144] #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95f7a0c
feat!: remove per-command --json from resource leaves
rianjs May 28, 2026
09a7c6c
docs(adding-a-domain): align with #144 — text-only resource leaves
rianjs May 28, 2026
e40179f
docs: drop stale printJSON() references after #144
rianjs May 28, 2026
1f767c8
test: end-to-end resource --json rejection + config show --json carve…
rianjs May 28, 2026
2a8772e
docs+test: align stale references; consolidate no-json assertion
rianjs May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ make install # Install to /usr/local/bin
- **Non-destructive by design**: Only allowlisted scopes in `auth.AllScopes`. No destructive API methods (send, delete, trash). Non-destructive modify operations (label, archive, star) are permitted.
- **Interface-at-consumer**: Each `internal/cmd/{domain}/output.go` defines its client interface.
- **ClientFactory DI**: Swappable factory for test mock injection.
- **--json on all leaf commands**: Every leaf subcommand supports `--json/-j`.
- **Text-only resource leaves (#144)**: Resource-surface leaf commands (under `mail`, `calendar`, `contacts`, `drive`, `me`) emit text only — they must NOT declare `--json/-j`. JSON is reserved for control-plane envelopes outside the domain resource packages: `gro refresh --json` (§4.6) and `gro config show --json` (diagnostic).
- **Structural enforcement**: `internal/architecture/architecture_test.go` enforces all patterns at CI time.

See `docs/golden-principles.md` for the full set of enforced rules.
Expand Down
Loading
Loading