Skip to content

gitops addon ManagedClusterAddOn failure with ManagedClusterAddOnLeas… #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

xiangjingli
Copy link
Collaborator

…eNotFound error, disable concurrent reconcile for ArgoCD pull model propagation controller

  • I have taken backward compatibility into consideration.

Two fixes are included:

https://issues.redhat.com/browse/ACM-20204
https://issues.redhat.com/browse/ACM-19762

…eNotFound error, disable concurrent reconcile for ArgoCD pull model propagation controller

Signed-off-by: Xiangjing Li <[email protected]>
@openshift-ci openshift-ci bot requested review from jnpacker and rokej April 22, 2025 16:25
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Copy link

openshift-ci bot commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikeshng,xiangjingli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (f8d354e) to head (ca5d924).
Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #125   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot openshift-merge-bot bot merged commit f485c02 into main Apr 22, 2025
9 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the gitopsAddonFix branch April 22, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants