fix: progressive sync for applicationSet needs to evaluate more application status fields #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mikeshng
commented
Apr 26, 2025
mikeshng
commented
- I have taken backward compatibility into consideration.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikeshng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
mikeshng
force-pushed
the
progressive-sync
branch
4 times, most recently
from
1f7b976 to
defe2a0
Compare
…cation status fields Signed-off-by: Mike Ng <[email protected]>
mikeshng
force-pushed
the
progressive-sync
branch
from
defe2a0 to
048b3d3
Compare
mikeshng
changed the title
|
/assign @xiangjingli |
|
/lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openshift-merge-bot
bot
merged commit 7b6cb0c
into
open-cluster-management-io:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.