Skip to content

No Resource List in Multiclusterapplicationsetreports of pull model i… #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

xiangjingli
Copy link
Collaborator

…f a standalone ArgoCD app is created on the managed cluster

  • I have taken backward compatibility into consideration.

https://issues.redhat.com/browse/ACM-19411

@openshift-ci openshift-ci bot requested review from fxiang1 and philipwu08 May 1, 2025 21:59
Copy link

openshift-ci bot commented May 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 1, 2025
…f a standalone ArgoCD app is created on the managed cluster

Signed-off-by: Xiangjing Li <[email protected]>
@fxiang1
Copy link
Collaborator

fxiang1 commented May 1, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 1, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 088ccc2 into main May 1, 2025
8 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the resourceListFix branch May 1, 2025 22:22
Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (f485c02) to head (7f229e4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #127   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants