Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

Conversation

@fxiang1
Copy link
Contributor

@fxiang1 fxiang1 commented Mar 20, 2025

  • I have taken backward compatibility into consideration.
  • Remove backup label from MSA since it's backed up by default

@openshift-ci openshift-ci bot requested review from chenz4027 and jnpacker March 20, 2025 17:30
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.79%. Comparing base (e85fafa) to head (90c523f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   55.51%   55.79%   +0.28%     
==========================================
  Files          96       96              
  Lines       15745    15742       -3     
==========================================
+ Hits         8741     8784      +43     
+ Misses       6121     6078      -43     
+ Partials      883      880       -3     
Flag Coverage Δ
unit 55.79% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fxiang1
Copy link
Contributor Author

fxiang1 commented Mar 20, 2025

/cc @xiangjingli

@openshift-ci openshift-ci bot requested a review from xiangjingli March 20, 2025 18:35
@xiangjingli
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 20, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 9d97ba7 into open-cluster-management-io:main Mar 20, 2025
9 checks passed
@fxiang1 fxiang1 deleted the feng-backuplabel branch March 20, 2025 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants