Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

Conversation

@mikeshng
Copy link
Member

  • I have taken backward compatibility into consideration.

@openshift-ci openshift-ci bot requested review from chenz4027 and jnpacker April 14, 2025 00:32
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikeshng
Copy link
Member Author

/assign @fxiang1

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.44%. Comparing base (a65388d) to head (b6ea374).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
- Coverage   55.79%   55.44%   -0.36%     
==========================================
  Files          96       96              
  Lines       15760    15760              
==========================================
- Hits         8794     8738      -56     
- Misses       6077     6138      +61     
+ Partials      889      884       -5     
Flag Coverage Δ
unit 55.44% <ø> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fxiang1
Copy link
Contributor

fxiang1 commented Apr 14, 2025

/lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants