✨ add CEL cost estimator #114
Open
+267
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqing0110
force-pushed
the
br_cel-cost
branch
from
c60c879 to
6ab360e
Compare
|
/assign @qiujian16 @zhujian7 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Qing Hao <[email protected]>
haoqing0110
force-pushed
the
br_cel-cost
branch
from
6ab360e to
49f4346
Compare
zhujian7
reviewed
Apr 25, 2025
| if cost := k8sEstimator.CallCost(function, overloadId, args, result); cost != nil { | ||
| return cost | ||
| } | ||
| return b.CostEstimator.CallCost(function, overloadId, args, result) |
There was a problem hiding this comment.
I am not famillar with the CostEstimator, want to understand who is expected to assign value for the BaseEnvCostEstimator.CostEstimator? should we add the nil check for the b.CostEstimator?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
open-cluster-management-io/ocm#843
open-cluster-management-io/ocm#955