Fix LLaVA model output issues by using official conversation templates#1424
Open
cdllI wants to merge 2 commits intoopen-compass:mainfrom
Open
Fix LLaVA model output issues by using official conversation templates#1424cdllI wants to merge 2 commits intoopen-compass:mainfrom
cdllI wants to merge 2 commits intoopen-compass:mainfrom
Conversation
kennymckormick
requested changes
Feb 26, 2026
vlmeval/vlm/llava/llava.py
Outdated
| ) | ||
|
|
||
| message = [dict(type="image", value=s) for s in tgt_path] | ||
| message = [dict(type="image", value=s) forin tgt_path] |
Author
There was a problem hiding this comment.
It was an accidental typo. I've fixed it.
vlmeval/vlm/llava/llava.py
Outdated
| else "\nAnswer the question directly." | ||
| ) | ||
| message = [dict(type="image", value=s) for s in tgt_path] | ||
| message = [dict(type="image", value=s) forin tgt_path] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
使用 conv_templates[conv_mode] 替代 self.system_prompt + "USER: " + content + " ASSISTANT: "
添加正确的图像标记处理（DEFAULT_IM_START_TOKEN, DEFAULT_IM_END_TOKEN）
Related to #817 #1029 #523