Skip to content

fix the vladbench download bug #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Depth2World wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −3
Open

fix the vladbench download bug #1497

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37185e3
fix bug
Depth2World Mar 25, 2026
792b2d8
Update IMAGE_DIR initialization logic
Depth2World Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions vlmeval/dataset/vladbench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,6 @@ class VLADBench(ImageBaseDataset):
}
DATASET_MD5 = {"VLADBench": "53c01aa8f9afe2d084728fc8eb21caea"}

IMAGE_DIR = None # e.g., your_localdir/VLADBench/
"""
Resolve VLADBench image directory.
Priority:
Expand All @@ -548,8 +547,12 @@ class VLADBench(ImageBaseDataset):
"""

def __init__(self, *args, **kwargs):
if self.IMAGE_DIR is None:
self.IMAGE_DIR = get_vladbench_image_dir(self.IMAGE_DIR)
local_dir = None # your_localdir/VLADBench/
Copy link
Copy Markdown
Collaborator

@mzr1996 mzr1996 Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The local_dir variable should be a parameter; otherwise, users have to change the source code to assign the variable.

if local_dir is None:
self.IMAGE_DIR = get_vladbench_image_dir(None)
else:
self.IMAGE_DIR = local_dir

super().__init__(*args, **kwargs)

def build_prompt(self, line: Union[int, pd.Series]) -> List[Dict[str, str]]:
Expand Down
Loading