fix: guard choices[0] and message=None before content access#1550
Open
qizwiz wants to merge 1 commit into
Open
fix: guard choices[0] and message=None before content access#1550qizwiz wants to merge 1 commit into
qizwiz wants to merge 1 commit into
Conversation
OpenAI-compatible APIs can return empty choices on error or content filtering; Gemini returns choices[0].message=None on PROHIBITED_CONTENT (HTTP 200). Both cause unhandled exceptions at runtime. Adds `if not response.choices or response.choices[0].message is None:` before every bare `choices[0].message.content` access across 3 files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenAI-compatible APIs can return empty
choiceson error or rate-limiting, causingIndexErroratchoices[0]. Gemini additionally returnschoices[0].message = NoneonPROHIBITED_CONTENTsafety filtering (HTTP 200 — no exception raised), causingAttributeErrorat.content.This PR adds the comprehensive guard:
before every bare
choices[0].message.contentaccess.Files changed (3 files, 3 sites)
vlmeval/dataset/simplevqa.py— comparison answer extractionvlmeval/api/glm_vision.py— GLM vision API adaptervlmeval/api/doubao_vl_api.py— Doubao VL API adapterVerification
The Gemini
choices[0].message = Nonecrash is a documented production behavior onPROHIBITED_CONTENTsafety filtering. Static analysis via pact (Z3 Fixedpoint datalog,llm_response_unguardedrule) found all 3 sites; post-fix scan returns 0 violations.