Handle recoverable truncated image payloads - #1554
Open
rajantripathi wants to merge 1 commit into
Open
Conversation
rajantripathi
force-pushed
the
fix-truncated-image-loading
branch
from
July 24, 2026 13:26
f892f39 to
8ad08dd
Compare
rajantripathi
force-pushed
the
fix-truncated-image-loading
branch
from
August 19, 2026 10:44
8ad08dd to
178bf28
Compare
Author
|
Rebased this PR onto the current upstream Current validation:
When convenient, could a maintainer review this fix for #1400? I am happy to adjust the implementation or test placement to match project preferences. |
rajantripathi
force-pushed
the
fix-truncated-image-loading
branch
from
September 2, 2026 15:01
178bf28 to
a873252
Compare
Author
|
Rebased onto the latest upstream main and tightened the implementation after another review. Strict Pillow decoding remains the default; only errors explicitly identified as truncated-image failures trigger a permissive retry, and the global Pillow flag is restored in a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Some benchmark TSVs contain recoverable truncated image payloads. A single recoverable image should not cause an entire evaluation combination to fail, but permissive decoding should also not remain enabled globally.
Fixes #1400.
Validation
mainpython3 -m py_compile vlmeval/smp/vlm.py tests/test_smp_vlm.py: passedImageFile.LOAD_TRUNCATED_IMAGESis restored after recoverygit diff --check origin/main...HEAD: passedFull pytest collection is not available in the local minimal environment because
pytestand the repository's optional benchmark dependency stack are not installed.