[Feature] Add multi-turn chat for Gemma 3, Mantis, and Pixtral - #1637
Open
reacher-z wants to merge 1 commit into
Open
[Feature] Add multi-turn chat for Gemma 3, Mantis, and Pixtral#1637reacher-z wants to merge 1 commit into
reacher-z wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat_innerfor Gemma 3 while preserving complete user/assistant history and images in both Transformers and vLLM backendschat_innerfor Mantis using its native conversation template, with a separate Idefics chat-template pathchat_innerfor Pixtral using native MistralUserMessage,AssistantMessage, andSystemMessagerequestsgenerate_innerpath working through shared generation helpersThis addresses another group of three models requested in #323. Their upstream documentation confirms the required capabilities:
Validation
python -m unittest -v tests/test_vlm_chat_inner_gemma_mantis_pixtral.py(8 tests passed)python -m py_compile vlmeval/vlm/gemma.py vlmeval/vlm/mantis.py vlmeval/vlm/pixtral.py tests/test_vlm_chat_inner_gemma_mantis_pixtral.pypre-commit run --files vlmeval/vlm/gemma.py vlmeval/vlm/mantis.py vlmeval/vlm/pixtral.py tests/test_vlm_chat_inner_gemma_mantis_pixtral.pyThe tests exercise Gemma's Transformers and vLLM paths, Mantis's native and Idefics paths, Pixtral's Mistral request construction, image ordering, role preservation, and single-turn regression behavior without downloading model weights.
AI assistance
OpenAI Codex assisted with implementation and testing. I reviewed the model capability sources, code paths, and test outputs before submission.