[Fix] Detect MIME types for extensionless images - #1643
Open
reacher-z wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unknownfor non-image files instead of raisingThis fixes the remaining SiteBenchImage failure reported in #1485. The 3DSRBench
name_strproblem from the same issue was already fixed by #1428.Why
Some SiteBenchImage assets have no filename extension.
parse_filecurrently maps an empty suffix tounknown, so API and model adapters cannot treat those paths as images even though Pillow can identify their encoded format.Tests
python3 -m pytest -q tests/test_smp_file.py(2 passed)uvx pre-commit run --files vlmeval/smp/file.py tests/test_smp_file.py(all passed)git diff --checkAI assistance disclosure
I used OpenAI Codex to inspect the issue and repository, implement the change, and draft tests and this description. I reviewed the code and personally ran the tests and checks above.
Closes #1485