Skip to content

[Update] Add CascadeEvaluator with Data Replica#2022

Merged
MaiziXiao merged 19 commits into
open-compass:mainfrom
tonysy:update_reasoning_eval
May 20, 2025
Merged

[Update] Add CascadeEvaluator with Data Replica#2022
MaiziXiao merged 19 commits into
open-compass:mainfrom
tonysy:update_reasoning_eval

Conversation

@tonysy

@tonysy tonysy commented Apr 14, 2025

Copy link
Copy Markdown
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Comment thread opencompass/configs/datasets/aime2024/aime2024_cascade_eval_gen_5e9f4f.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it by purpose that some dataset configs are using Parallel = False and some not?

Comment on lines 3 to 16

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And reasong to comment these summary_groups configs?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid useless config for the default example.

Comment thread opencompass/utils/run.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment

@MaiziXiao MaiziXiao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ipdb comments

Comment on lines 95 to 102

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call this function in the evaluate() function to preprocess the predictions

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the postprocess in BaseEvaluator instead of doing it here

@tonysy tonysy force-pushed the update_reasoning_eval branch from ccd5daf to cf7f242 Compare May 14, 2025 10:20
@tonysy tonysy requested a review from MaiziXiao May 14, 2025 10:22

@MaiziXiao MaiziXiao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhulinJulia24 zhulinJulia24 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MaiziXiao MaiziXiao merged commit aa2b89b into open-compass:main May 20, 2025
11 of 14 checks passed
iamkaia pushed a commit to iamkaia/opencompass that referenced this pull request Feb 4, 2026
* Update CascadeEvaluator

* Update CascadeEvaluator

* Update CascadeEvaluator

* Update Config

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants