[BB-9572] Implement new MFE #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agrendalath
reviewed
Apr 1, 2025
pkulkark
force-pushed
the
pooja/bb9572-implement-new-mfe
branch
from
ad33c6b to
3fb6226
Compare
Moving it to the right was causing the modal to go outside the viewport on narrow screens.
It was pulling a random completion for staff users otherwise.
The completion was showing a NaN on the LearningPathDetails page.
This gets rid of the browser's console error.
SCSS styling will be deprecated after Teak. Also, CSS natively supports nesting: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_nesting/Using_CSS_nesting
Note: we may need to consider using the `release/*` branches.
The newer version does not work with Redwood header.
It's more accurate, as this component displays courses, too.
Navigating to the previous page in the browser causes the modal to reopen, which is confusing.
Port 8080 is commonly used, so it's likely to cause conflicts.
Agrendalath
force-pushed
the
pooja/bb9572-implement-new-mfe
branch
from
354baba to
a5f1f2c
Compare
Agrendalath
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
👍
- I tested this: tested this with https://github.com/open-craft/learning-paths-plugin
- I read through the code
- I checked for accessibility issues: no, though this should be partially covered by Paragon
- Includes documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD