Merged
Conversation
`defaultProps` will be removed in a future major release.
This will allow us to reuse this function.
Using the navigation instead of checking the state allows us to support the native browser navigation functionality.
This also replaced some placeholder subtexts.
Agrendalath
force-pushed
the
agrendalath/bb-9669-enrollments
branch
from
db18d87 to
6b6b9f8
Compare
We don't need to encode it when it's not a query string.
Agrendalath
force-pushed
the
agrendalath/bb-9669-enrollments
branch
from
e1e6037 to
fba71b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See open-craft/learning-paths-plugin#19.
Private-ref: BB-9669