Conversation
4ec69aa to
c5e289f
Compare
c5e289f to
3c5eb2e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sandbox-header #6 +/- ##
=================================================
Coverage ? 68.75%
=================================================
Files ? 48
Lines ? 432
Branches ? 97
=================================================
Hits ? 297
Misses ? 132
Partials ? 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xitij2000
left a comment
There was a problem hiding this comment.
I think generally in all of these slots the pluginProps should be something that the plugin can't get in other ways. It will be part of the plugin's API and can't be changed once set. So I don't think these should be added.
| slotOptions={{ | ||
| mergeProps: true, | ||
| }} | ||
| pluginProps={props} |
There was a problem hiding this comment.
pluginProps are the API for plugin slots, so they should only pass along necessary options conservatively.
|
Thanks, @xitij2000 . Pending resolution of this comment, this entire PR may be unnecessary-- though I'll likely instead want to create one for the menu activator on desktop, as you mentioned. |
|
@xitij2000 Rethinking it, the logo's pretty simple and the data it gets can be pulled from the context hook, so I don't even need the props there. Closing this. |
This MR prototypes our header design for sandboxes.
JIRA ticket: https://tasks.opencraft.com/browse/STAR-4174
Figma Design: https://www.figma.com/design/c5SgVI3M8VmkeMajJu3EFK/OpenCraft-Sandbox-Designs?node-id=0-1&p=f&t=WfH1TjTB0XE4f8lw-0
Screenshots:
Sandbox URL: TBD - sandbox is being provisioned.
Merge deadline: "None" if there's no rush, "ASAP" if it's critical, or provide a specific date if there is one.
Testing instructions:
npm cito install the requirementsfox/sandboxbranch.npm run startto run the local serverAuthor notes and concerns:
This PR is not intended to actually be merged. It's here to show how I've prototyped the plugins locally. I've not yet dug into the best method of distributing these changes, but I do have them working locally this way, so taking the time to have them reviewed now before doing anything else.
The mobile header also doesn't quite match the design, since implementing it looked to be more complex than we had remaining time for.
Additionally, the avatar icon is upstream's icon, since I was not sure where it would be best to place/host a replacement icon file, and it was decently similar.