fix: update and add quality tests

[samuelallan72]

Description

• update requirements
• update pylint from edx-lint
• configure quality tests and linters: pylint, isort, black
• fix the code to pass the lints
• update .github files

Supporting information

Private-ref: https://tasks.opencraft.com/browse/BB-10035

Test instructions

• verify the CI passes
• clone locally and run tox -e quality
• also test the api endpoints to verify behaviour hasn't changed - see feat: upgrade to support sumac release #1 and fix: inline old shoppingcart for enrollment codes #2

Deadline

None

[Kelketek]

@samuelallan72 I've done a readthrough and these changes make sense to me. I may circle back to test the endpoints manually after some other work today, but I'm just as happy to let @tecoholic test it since I think he's already got it set up.

[samuelallan72]

@tecoholic the diff is fairly large, and I was worried about creating subtle bugs by mixing refactoring with reformatting. So I split this into 3 commits, which may make it easier to review separately:

1. changes to all the scaffolding files
2. reformatting (this is only the result of running make format)
3. refactoring and tweaks to fix quality checks

A few minor things changed in the process (nothing functional) - you can check those with the "compare" button next to the force push message above.

cc @Kelketek

[tecoholic]

@samuelallan72 Amazing work on getting this repo to shape. If we sort out Black's config to match Pylint's rules on line-legth, I think we are good here.

[tecoholic]

Related to the comment on Black & line legth - we can replace this setup.cfg with pyproject.toml.

[tecoholic]

Suggested change

	"Programming Language :: Python :: 3.5",
	"Programming Language :: Python :: 3.11",

[tecoholic]

@samuelallan72 Oh! Thank you for the 3 clean commits. It was a breeze to review the PR.

[samuelallan72]

Thanks @tecoholic ! :)

I addressed your comment about the line length, and responded to your other comments. Not sure if you'd like any of your other comments addressed here before merge?

I also added a commit to fix a minor security issue - 6a60578

I did force push sorry, just to keep the commits all neat still. I guess next time I should submit them as separate PRs to avoid that.

This should be ready for another pass. :)

[tecoholic]

@samuelallan72 👍 LGTM

• I tested this: Ran the quality checks and formatting locally.
• I read through the code
• I checked for accessibility issues - NA
• Includes documentation