Conversation
9803723 to
dee0755
Compare
591a4b1 to
6a60578
Compare
dee0755 to
8bee5c7
Compare
9ae722f to
ba820c3
Compare
789a4b4 to
6bfadc8
Compare
- remove unused files - update dependencies - do some minor tidying - add manual test instructions - clarify AGPLv3 license Private-ref: https://tasks.opencraft.com/browse/BB-10035
6bfadc8 to
2b0314b
Compare
Kelketek
left a comment
There was a problem hiding this comment.
@samuelallan72 I went ahead and reviewed this since I knew @tecoholic would already have a setup with it working, but I wouldn't, so it would be a better test. I did find a few issues.
@tecoholic Since @samuelallan72 is out the rest of the week, if you happen to have free time (other tasks in this epic are higher priority) and can address the notes, feel free to do so and I'll do another review pass.
I'll be back tomorrow (Thursday); I just took today off. 😄 Of course if you have time @tecoholic , feel free to push any changes! :) |
|
@samuelallan72 Whoops! I misread your message on Mattermost. Cool-- noted, and thanks! |
|
@Kelketek I addressed your review comments and made some general usability improvements to the manual tests. This is ready for another review pass. :) cc @tecoholic |
There was a problem hiding this comment.
👍
- I tested this: Migration tests and manual test plan
- I read through the code
-
I checked for accessibility issues - Includes documentation
-
Added to the Code Drift project board (for backports)
Description
Add instructions for manually testing the plugin on a devstack.
Also do some tidying of the repo, removing unused files, clarifying the license, and fixing some minor issues I discovered on the way.
Also add a pull request template to remind developers to do the manual testing, because there are no tests in CI (apart from the quality lints).
Supporting information
Private-ref: BB-10035
Test instructions
Deadline
None