Skip to content

Add test instructions and some tidying#4

Merged
Kelketek merged 3 commits intomainfrom
samuel/tests
Oct 2, 2025
Merged

Add test instructions and some tidying#4
Kelketek merged 3 commits intomainfrom
samuel/tests

Conversation

@samuelallan72
Copy link
Copy Markdown
Member

@samuelallan72 samuelallan72 commented Sep 25, 2025

Description

Add instructions for manually testing the plugin on a devstack.

Also do some tidying of the repo, removing unused files, clarifying the license, and fixing some minor issues I discovered on the way.

Also add a pull request template to remind developers to do the manual testing, because there are no tests in CI (apart from the quality lints).

Supporting information

Private-ref: BB-10035

Test instructions

  • View the rendered README.md and ./docs/manual-test-plan.md to check for formatting issues.
  • Follow the test instructions and devstack installation instructions in the README and verify everything works as expected.
  • Follow the playbook in ./docs/manual-test-plan.md and verify the instructions are clear, easy to follow, and work as expected.

Deadline

None

@samuelallan72 samuelallan72 self-assigned this Sep 25, 2025
@samuelallan72 samuelallan72 force-pushed the samuel/tests branch 2 times, most recently from 9803723 to dee0755 Compare September 26, 2025 06:04
Base automatically changed from samuel/quality to main September 29, 2025 01:33
@samuelallan72 samuelallan72 force-pushed the samuel/tests branch 7 times, most recently from 9ae722f to ba820c3 Compare September 29, 2025 07:19
@samuelallan72 samuelallan72 changed the title wip: add tests Add test instructions and some tidying Sep 29, 2025
@samuelallan72 samuelallan72 force-pushed the samuel/tests branch 3 times, most recently from 789a4b4 to 6bfadc8 Compare September 30, 2025 01:49
- remove unused files
- update dependencies
- do some minor tidying
- add manual test instructions
- clarify AGPLv3 license

Private-ref: https://tasks.opencraft.com/browse/BB-10035
@samuelallan72 samuelallan72 marked this pull request as ready for review September 30, 2025 02:06
Copy link
Copy Markdown
Member

@Kelketek Kelketek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelallan72 I went ahead and reviewed this since I knew @tecoholic would already have a setup with it working, but I wouldn't, so it would be a better test. I did find a few issues.

@tecoholic Since @samuelallan72 is out the rest of the week, if you happen to have free time (other tasks in this epic are higher priority) and can address the notes, feel free to do so and I'll do another review pass.

Comment thread README.md
Comment thread README.md
Comment thread docs/manual-test-plan.md Outdated
Comment thread docs/manual-test-plan.md
Comment thread docs/manual-test-plan.md Outdated
Comment thread docs/manual-test-plan.md Outdated
Comment thread docs/manual-test-plan.md Outdated
@samuelallan72
Copy link
Copy Markdown
Member Author

samuelallan72 commented Oct 1, 2025

@Kelketek @tecoholic

Since @samuelallan72 is out the rest of the week,

I'll be back tomorrow (Thursday); I just took today off. 😄 Of course if you have time @tecoholic , feel free to push any changes! :)

@Kelketek
Copy link
Copy Markdown
Member

Kelketek commented Oct 1, 2025

@samuelallan72 Whoops! I misread your message on Mattermost. Cool-- noted, and thanks!

@samuelallan72
Copy link
Copy Markdown
Member Author

@Kelketek I addressed your review comments and made some general usability improvements to the manual tests. This is ready for another review pass. :) cc @tecoholic

Copy link
Copy Markdown
Member

@Kelketek Kelketek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: Migration tests and manual test plan
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation
  • Added to the Code Drift project board (for backports)

@Kelketek Kelketek merged commit f164f0d into main Oct 2, 2025
1 check passed
@Kelketek Kelketek deleted the samuel/tests branch October 2, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants