Search Index Rebuild UI and After Org Update #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Re-index orgs after update. - Re-index UI views and actions.
- Added progres bar for search rebuild; - Finalized site index rebuild.
- Added change log file.
wardi
reviewed
Nov 29, 2024
wardi
reviewed
Nov 29, 2024
wardi
reviewed
Nov 29, 2024
wardi
reviewed
Nov 29, 2024
wardi
reviewed
Nov 29, 2024
wardi
reviewed
Nov 29, 2024
wardi
reviewed
Nov 29, 2024
wardi
reviewed
Nov 29, 2024
wardi
reviewed
Nov 29, 2024
wardi
reviewed
Nov 29, 2024
wardi
reviewed
Nov 29, 2024
- Feedback round 1.
Author
|
@wardi are you able to re-review this one? |
wardi
reviewed
Nov 29, 2024
wardi
reviewed
Nov 29, 2024
wardi
reviewed
Nov 29, 2024
wardi
reviewed
Nov 29, 2024
wardi
reviewed
Nov 29, 2024
- Set enumerate starter.
- Task type `search_rebuild` -> `reindex_packages`.
wardi
reviewed
Nov 29, 2024
- Updated reindex action method names to CKAN standards.
- Python coding standards.
wardi
approved these changes
Nov 29, 2024
Member
wardi
left a comment
wardi
left a comment
There was a problem hiding this comment.
looks great. This will be an amazing feature to get upstream
- Added method doc comments for job callback.
- Show errors even if not verbose.
- TODO comment.
- Do query for group re-indexing.
- Handle null values in progress bar JS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
Basic issue is that the Org/Group names are in dataset SOLR records. This would be an issue if an Org/Group title or name is updated, their dataset's won't show this in
package_searchor anything else that queries the SOLR index. So this adds some logic functions to re-index an Org/Group's records after the title or name changes.It does this in a background task. So this would require some documentation regarding that.
This also implements some task_status stuff for this and adds in some UIs to sysadmins to be able to re-index from the Admin views. And adds a progress bar to see the status of the re-index.