Skip to content

DataStore Filtering for Text Arrays #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JVickery-TBS merged 2 commits into from
May 16, 2025
Merged

DataStore Filtering for Text Arrays #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42c2072
fix(logic): datastore text array filters;
JVickery-TBS May 16, 2025
a0eb300
feat(misc): changelog;
JVickery-TBS May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/199.canada.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Now properly handles string filtering for DataStore text array (`_text`) fields.
12 changes: 12 additions & 0 deletions ckanext/datastore/backend/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,18 @@ def _where_clauses(
# this fixes parity there.
value = (str(v) for v in value)
clause = (clause_str, dict(zip(placeholders, value)))
elif isinstance(value, str) and field_array_type:
# (canada fork only): transform string filters for _text type
# TODO: upstream contrib!!
value = [v.strip() for v in value.split(',')]
placeholders = [
f"value_{next(idx_gen)}" for _ in value
]
clause_str = ('{0} && ARRAY[{1}]'.format(
sa.column(field),
','.join(f":{p}" for p in placeholders)
))
clause = (clause_str, dict(zip(placeholders, value)))
else:
if fields_types[field] == 'text':
# pSQL can do int_field = "10"
Expand Down