NoOpener & NoReferrer for _blank Targets #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `noopener noreferrer` to all anchors with `_blank` targets.
- Added change log file.
wardi
reviewed
Aug 18, 2025
Member
wardi
left a comment
wardi
left a comment
There was a problem hiding this comment.
This changes some translated strings, make sure to update the translations too or we might be missing some fr versions of the text on our site (do we override these in our theme?)
Author
|
Ah good point, and no overriding of these things. Just putting into our plugin strings.py cuz I don't like dealing with changing the PO files in the CKAN fork. |
Author
|
I lied, it might be easier to just compile the catalog in here. hmmm and then merging stuff from upstream we can always just re-extract and re-compile. Should not be a big problem. |
- Build and unfuzzy FR strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the VA scan, all _blank targets should have rel="noopener norefferer" even if they are https and/or on the same domain.