Skip to content

Datatables BOM for Just CSV/TSV #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JVickery-TBS merged 2 commits into from
Sep 3, 2025
Merged

Datatables BOM for Just CSV/TSV #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b653ac9
fix(views): datatables bom;
JVickery-TBS Sep 2, 2025
95b8bb9
feat(misc): changelog;
JVickery-TBS Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/206.canada.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Only output a BOM for CSV and TSV files in Datatables' filter download.
3 changes: 2 additions & 1 deletion ckanext/datatablesview/blueprint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,8 @@ def filtered_download(resource_view_id: str):
u'filters': json.dumps(filters),
u'format': request.form[u'format'],
u'fields': u','.join(cols),
u'bom': True,
# (canada fork only): BOM for CSVs and TSVs
'bom': request.form['format'] in ['csv', 'tsv', 'CSV', 'TSV'],
}))


Expand Down