Skip to content

Password Autocomplete Off #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JVickery-TBS merged 2 commits into from
Sep 12, 2025
Merged

Password Autocomplete Off #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9caa313
feat(templates) autocomplete;
JVickery-TBS Sep 10, 2025
68a805c
feat(misc): changelog;
JVickery-TBS Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/207.canada.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added `autocomplete=off` for password fields to secure fields for older browser architecture
8 changes: 5 additions & 3 deletions ckan/templates/user/perform_reset.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,15 @@ <h1 class="page-heading">
<form action="" method="post">
{{ h.csrf_input() }}
{{ form.errors(error_summary) }}
{# (canada fork only): autocomplete=off #}
{% if user_dict['state'] == 'pending' %}
<p>{{ _('You can also change username. It can not be modified later.') }}</p>
{{ form.input("name", id="field-name", label=_("Username"), type="text", value=user_dict["name"],
error=errors.name, attrs={'autocomplete': 'no', 'class': 'form-control control-medium'}, classes=["form-group"]) }}
error=errors.name, attrs={'autocomplete': 'off', 'class': 'form-control control-medium'}, classes=["form-group"]) }}
{% endif %}
{{ form.input("password1", id="field-password", label=_("Password"), type="password", value='', error=errors.password1, attrs={'autocomplete': 'no', 'class': 'form-control control-medium'}, classes=["form-group"]) }}
{{ form.input("password2", id="field-confirm-password", label=_("Confirm"), type="password", value='', error=errors.password2, attrs={'autocomplete': 'no', 'class': 'form-control control-medium'}, classes=["form-group"]) }}
{# (canada fork only): autocomplete=off #}
{{ form.input("password1", id="field-password", label=_("Password"), type="password", value='', error=errors.password1, attrs={'autocomplete': 'off', 'class': 'form-control control-medium'}, classes=["form-group"]) }}
{{ form.input("password2", id="field-confirm-password", label=_("Confirm"), type="password", value='', error=errors.password2, attrs={'autocomplete': 'off', 'class': 'form-control control-medium'}, classes=["form-group"]) }}
<div class="form-actions">
{% block form_button %}
<button class="btn btn-primary" type="submit" name="save">{{ _("Update Password") }}</button>
Expand Down