Skip to content

Do Not Manipulate Fake Path #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JVickery-TBS merged 3 commits into from
Sep 12, 2025
Merged

Do Not Manipulate Fake Path #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67428c8
feat(js): safer js;
JVickery-TBS Sep 11, 2025
261da62
feat(misc): changelog;
JVickery-TBS Sep 11, 2025
edaf7ea
feat(misc): changelog;
JVickery-TBS Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/208.canada.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Front end resource upload no longer manipulates the upload field's fake path.
10 changes: 8 additions & 2 deletions ckan/public/base/javascript/modules/resource-upload-field.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,17 @@ this.ckan.module('resource-upload-field', function (jQuery) {
urlField.attr('type', 'url');
})

$('#field-resource-upload').on('change', function() {
$('#field-resource-upload').on('change', function(_event) { // (canada fork only): use File API
if (_nameIsDirty) {
return;
}
var file_name = $(this).val().split(/^C:\\fakepath\\/).pop();

// (canada fork only): use File API
const selectedFile = _event.target.files[0];
let file_name = '';
if( selectedFile ){
file_name = selectedFile.name;
}

// Internet Explorer 6-11 and Edge 20+
var isIE = !!document.documentMode;
Expand Down