-
Notifications
You must be signed in to change notification settings - Fork 868
chore(imports): reduce startup time #3257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ashwinvaidya17
wants to merge
16
commits into
open-edge-platform:feature/geti-inspect
Choose a base branch
from
ashwinvaidya17:ashwin/startup_time
base: feature/geti-inspect
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2b68acc
Reduce startup time
ashwinvaidya17 974974f
Merge branch 'feature/geti-inspect' into ashwin/startup_time
ashwinvaidya17 7349e14
update uv.lock
ashwinvaidya17 c165bc7
fix training
ashwinvaidya17 75e0285
revert files with minor changes
ashwinvaidya17 4b88a83
Apply suggestions from code review
ashwinvaidya17 1db5fa0
Reduce function complexity
ashwinvaidya17 9a131c2
Merge branch 'feature/geti-inspect' into ashwin/startup_time
ashwinvaidya17 dc7118d
fix(ci): install FFmpeg dependencies for av package build
ashwinvaidya17 22d8f2b
Update pyproject.toml
ashwinvaidya17 7bcd8f9
revert changes to action
ashwinvaidya17 36846f9
revert video req
ashwinvaidya17 b1b758e
update lockfile
ashwinvaidya17 655b49c
Add deps to action yaml
ashwinvaidya17 4254929
remove ffmpeg
ashwinvaidya17 833002a
Add build-tools stage
ashwinvaidya17 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -68,10 +68,9 @@ async def _run_training_job(cls, job: Job, job_service: JobService) -> Model | N | |||||
| project_id = job.project_id | ||||||
| model_name = job.payload.get("model_name") | ||||||
| device = job.payload.get("device") | ||||||
| snapshot_id_ = job.payload.get("dataset_snapshot_id") | ||||||
| snapshot_id = UUID(snapshot_id_) if snapshot_id_ else None | ||||||
| max_epochs = job.payload.get("max_epochs", 200) | ||||||
|
|
||||||
| snapshot_id = UUID(snapshot_id_str) if (snapshot_id_str := job.payload.get("dataset_snapshot_id")) else None | ||||||
|
||||||
| snapshot_id = UUID(snapshot_id_str) if (snapshot_id_str := job.payload.get("dataset_snapshot_id")) else None | |
| snapshot_id = UUID(dataset_snapshot_id_str) if (dataset_snapshot_id_str := job.payload.get("dataset_snapshot_id")) else None |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function uses
np.ndarrayas a type annotation but numpy is now only imported in the TYPE_CHECKING block. This will cause a NameError at runtime. Either import numpy unconditionally or use a string literal for the type annotation:image: 'np.ndarray'.