Skip to content

fix: use .selectorLabels in selectors#24

Merged
andybavier merged 1 commit intomainfrom
i27227
Apr 21, 2025
Merged

fix: use .selectorLabels in selectors#24
andybavier merged 1 commit intomainfrom
i27227

Conversation

@andybavier
Copy link
Copy Markdown

@andybavier andybavier commented Apr 21, 2025

Description

The CCG Helm chart currently cannot be upgraded. We see this message:

error when patching "/dev/shm/2500439089": Deployment.apps "cluster-connect-gateway-gateway" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/component":"gateway", "app.kubernetes.io/instance":"cluster-connect-gateway", "app.kubernetes.io/managed-by":"Helm", "app.kubernetes.io/name":"cluster-connect-gateway", "app.kubernetes.io/version":"1.1.0-dev-f075b087", "helm.sh/chart":"cluster-connect-gateway-1.1.0-dev"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

The root cause is that the Helm chart is including selector labels that change per chart version. We should be using the .selectorLabels here instead of .labels.

Fixes # (issue)

Any Newly Introduced Dependencies

Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I agree to use the APACHE-2.0 license for my code changes
  • I have not introduced any 3rd party dependency changes
  • I have performed a self-review of my code

@andybavier andybavier merged commit 517b233 into main Apr 21, 2025
15 checks passed
@andybavier andybavier deleted the i27227 branch April 21, 2025 18:44
andybavier pushed a commit that referenced this pull request Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants