[GST gvawatermark] document explicit enable-blur flag usage#757
Open
walidbarakat wants to merge 1 commit intomainfrom
Open
[GST gvawatermark] document explicit enable-blur flag usage#757walidbarakat wants to merge 1 commit intomainfrom
walidbarakat wants to merge 1 commit intomainfrom
Conversation
walidbarakat
requested review from
a team,
BaoHuiling,
OskarFiedot,
ZiningLi,
dmichalo,
jmotow,
marcin-wadolkowski,
mholowni,
msmiatac,
nszczygl9,
oonyshch,
pbartosik,
qianlongding,
tbujewsk,
tjanczak,
yangjianfeng1208 and
yunowo
as code owners
marcin-wadolkowski
previously approved these changes
Apr 10, 2026
jmotow
previously approved these changes
Apr 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates gvawatermark documentation to clarify that the enable-blur display config flag must be explicitly enabled for ROI blurring behavior, independent of any ROI blur include/exclude filters.
Changes:
- Added an
enable-blurusage note to the element’sdispl-cfgproperty description (gst-inspect style output). - Added corresponding notes in the user guide property list and in the “Blur Configuration Parameters” section.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/monolithic/gst/elements/gvawatermark/gstgvawatermarkimpl.h | Extends displ-cfg option description to mention explicit enable-blur requirement. |
| docs/user-guide/elements/gvawatermark.md | Adds notes explaining enable-blur must be set to activate blurring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dmichalo
previously approved these changes
Apr 10, 2026
tbujewsk
previously approved these changes
Apr 10, 2026
walidbarakat
dismissed stale reviews from tbujewsk, dmichalo, jmotow, and marcin-wadolkowski
via
5d4d054
walidbarakat
force-pushed
the
update_watermark_ROI_filter_doc
branch
from
4a22da8 to
5d4d054
Compare
mholowni
approved these changes
Apr 10, 2026
dmichalo
approved these changes
Apr 10, 2026
walidbarakat
force-pushed
the
update_watermark_ROI_filter_doc
branch
from
5d4d054 to
a66af43
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
update gvawatermark documentation to explicit the need for "enable-blur" flag to enable the blurring feature either ROI blur filter is enabled or not. Signed-off-by: Walid <walid.aly@intel.com>
walidbarakat
force-pushed
the
update_watermark_ROI_filter_doc
branch
from
a66af43 to
d2e502b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
update gvawatermark documentation to explicit the need for "enable-blur" flag to enable the blurring feature either ROI blur filter is enabled or not.
Checklist: