Skip to content

[DLStreamer] Reorganization of workflows - one main per PR, two per PR sub-workflows (dev_img and deb_pkg+bin_img), weekly Docker img build#157

Merged
nszczygl9 merged 39 commits intomainfrom
build-deb-packages
May 15, 2025
Merged

[DLStreamer] Reorganization of workflows - one main per PR, two per PR sub-workflows (dev_img and deb_pkg+bin_img), weekly Docker img build#157
nszczygl9 merged 39 commits intomainfrom
build-deb-packages

Conversation

@nszczygl9
Copy link
Copy Markdown
Contributor

No description provided.

@tbujewsk tbujewsk requested a review from dmichalo May 12, 2025 21:13
@nszczygl9 nszczygl9 marked this pull request as draft May 13, 2025 06:12
Comment thread microservices/dlstreamer-pipeline-server/docker/docker-compose.yml Outdated
Comment thread .github/workflows/dls-build-deb-packages-and-images.yaml Outdated
Comment thread .github/workflows/dls-pr-workflow.yaml Outdated
Comment thread .github/workflows/dls-pr-workflow.yaml Outdated
Comment thread .github/workflows/dls-build-dev-docker-images.yaml
Comment thread .github/workflows/dls-build-dev-docker-images.yaml Outdated
Comment thread .github/workflows/dls-build-deb-packages-and-images.yaml
Comment thread .github/workflows/dls-build-deb-packages-and-images.yaml Outdated
Comment thread .github/workflows/dls-build-deb-packages-and-images.yaml Outdated
Comment thread .github/workflows/dls-build-dev-docker-images.yaml
Comment thread .github/workflows/dls-build-weekly-deb-image.yaml Outdated
@dmichalo dmichalo changed the title [DLStreamer] Create action for building .deb packages. [DLStreamer] Reorganization of workflows - one main per PR, two per PR sub-workflows (dev_img and deb_pkg+bin_img), weekly Docker img build May 14, 2025
Copy link
Copy Markdown
Contributor

@xwu2intel xwu2intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a general comment. The build step takes more than 33 minutes and still going. It might be better to carefully design conditions to trigger this CI step. Add more detailed filters to skip the build steps if a PR change does not affect the build, for example, documentation changes.

@nszczygl9 nszczygl9 requested review from dmichalo and tbujewsk May 14, 2025 15:57
Comment thread microservices/dlstreamer-pipeline-server/docker/.env Outdated
Comment thread microservices/dlstreamer-pipeline-server/docker/docker-compose.yml Outdated
Comment thread .github/workflows/dls-build-weekly-deb-image.yaml Outdated
Copy link
Copy Markdown
Contributor

@ajagadi1 ajagadi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nszczygl9
Copy link
Copy Markdown
Contributor Author

@xwu2intel Thank you for that observation; it's a good and accurate insight. We will try to optimize it in next week using docker cache solutions.

@nszczygl9 nszczygl9 requested a review from dmichalo May 15, 2025 11:29
@nszczygl9 nszczygl9 merged commit 52ba1eb into main May 15, 2025
8 checks passed
@dmichalo dmichalo deleted the build-deb-packages branch May 19, 2025 14:21
nszczygl9 added a commit that referenced this pull request Dec 16, 2025
…R sub-workflows (dev_img and deb_pkg+bin_img), weekly Docker img build (#157)

Co-authored-by: Tomasz Bujewski <tomasz.bujewski@intel.com>
Co-authored-by: Dawid Michalowski <dawid.michalowski@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants