Real Time Audio Processing #1046
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonikaReddyT
requested review from
avinash-palleti and
unarayan
as code owners
unarayan
reviewed
Nov 14, 2025
| stdout=subprocess.DEVNULL, | ||
| stderr=subprocess.DEVNULL | ||
| ) | ||
| silences = detect_silences(segment_file) |
Contributor
There was a problem hiding this comment.
The silence detection points seems to be based on segment file, however in process audio segment full file is send. this probably isn't spliting the file correctly.
unarayan
reviewed
Nov 14, 2025
| end_time = get_closest_silence(silences, ideal_end) or min(ideal_end, duration) | ||
| if end_time <= current_time: | ||
| end_time = min(ideal_end, duration) | ||
| cut_by_silence = False |
unarayan
requested changes
Nov 14, 2025
Contributor
unarayan
left a comment
unarayan
left a comment
There was a problem hiding this comment.
Changes in Silence Detection for Audio Stream is required
unarayan
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of following updates