Skip to content

Conversation

@saratpoluri
Copy link
Contributor

@saratpoluri saratpoluri commented Nov 13, 2025

Description

Modify the docker compose file to use a volume mount for storing the downloaded node modules so it only needs network connection for the first deployment. Successive runs will not require network connection and the application can be run completely airgapped.

Fixes #870

Any Newly Introduced Dependencies

Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I agree to use the APACHE-2.0 license for my code changes.
  • I have not introduced any 3rd party components incompatible with APACHE-2.0.
  • I have not included any company confidential information, trade secret, password or security token.
  • I have performed a self-review of my code.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables airgapped deployment by persisting Node.js dependencies in Docker volumes. After the first deployment downloads node modules, subsequent runs can operate without network connectivity by reusing the cached modules.

Key Changes:

  • Added persistent volume mount for node_modules in Node-RED service
  • Simplified entrypoint configuration by mounting entire node-red directory
  • Standardized device_cgroup_rules quote style

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
compose-without-scenescape.yml Added node-red-node-modules volume mount and declaration
compose-scenescape.yml Added node-red-node-modules volume, simplified volume mounts and entrypoint by mounting full directory, standardized quotes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +165 to +167
- "c 189:* rmw"
- "c 209:* rmw"
- "a 189:* rwm"
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The quote style change from single quotes to double quotes is inconsistent with the stated purpose of this PR (persisting node modules). This appears to be an unrelated formatting change that should either be part of a separate PR or explained in the description.

Copilot uses AI. Check for mistakes.
vagheshp
vagheshp previously approved these changes Nov 17, 2025
Copy link
Contributor

@vagheshp vagheshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] smart intersection - Node red fails to start without internet connection

4 participants