[Metro AI Suite] Live Video Captioning Helm Chart#2351
[Metro AI Suite] Live Video Captioning Helm Chart#2351yogeshmpandey wants to merge 41 commits intoopen-edge-platform:mainfrom
Conversation
…ate Docker image and improve model download script with weight format options
…_HISTORY configuration
…I to display error messages
- Introduced helper functions to build pipeline parameters and payloads for starting runs. - Updated the start_run endpoint to utilize the new helper functions for cleaner code. - Added tests to ensure optional pipeline parameters are correctly forwarded to the server. - Created AGENTS.md for project documentation and guidelines.
…e-ai-suites into lvc_helm_chart
…pdate documentation for improved clarity on deployment requirements and known issues.
…ed clarity and functionality
yogeshmpandey
requested review from
a team,
bharagha and
hteeyeoh
as code owners
…oning configuration
| {{/* | ||
| Copyright (C) 2026 Intel Corporation | ||
| SPDX-License-Identifier: Apache-2.0 | ||
| */}} |
There was a problem hiding this comment.
Thought: Collector helm here or with the metrics?
There was a problem hiding this comment.
I have decoupled it to individual subcharts.
| */}} | ||
|
|
||
| {{- define "collector.name" -}} | ||
| {{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" }} |
There was a problem hiding this comment.
Added | lower to *.name, *.fullname, and *.chart template functions to enforce Kubernetes lowercase naming requirements.
| app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} | ||
| {{- end }} | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| app.kubernetes.io/part-of: live-video-captioning |
There was a problem hiding this comment.
Can we parameterize this "part-of" in case of multiple other consumers of this microservice?
There was a problem hiding this comment.
Replaced hardcoded app.kubernetes.io/part-of: live-video-captioning.
| interval = "10s" | ||
| [[inputs.execd]] | ||
| command = ["python3", "/app/qmassa_reader.py"] |
There was a problem hiding this comment.
Same comment applies in other places. Assumed to exist right? What if it is not there?
There was a problem hiding this comment.
Added comments clarifying that read_cpu_freq.sh and qmassa_reader.py are bundled inside the collector container image
| path: {{ .Values.collectorSignalsHostPath | quote }} | ||
| type: DirectoryOrCreate | ||
| - name: host-sys | ||
| hostPath: |
There was a problem hiding this comment.
assuming privileged mounting is required given it is telemetry
| replicas: {{ .Values.replicaCount }} | ||
| strategy: | ||
| type: Recreate | ||
| rollingUpdate: null |
There was a problem hiding this comment.
Yes, with RollingUpdate, Kubernetes tries to start the new pod before terminating the old one. That would fail immediately with a port-already-in-use error as we are running on host.
Recreate is the correct strategy here as the pod will terminate before the next is created.
| ports: | ||
| - name: turn-udp | ||
| containerPort: {{ .Values.service.port }} | ||
| hostPort: {{ .Values.service.nodePort }} |
There was a problem hiding this comment.
replica > 1 will fail right due to conflict on host port?
There was a problem hiding this comment.
Added guards in each deployment template, updated helm README also.
| ports: | ||
| - name: metrics | ||
| containerPort: {{ .Values.service.port }} | ||
| hostPort: {{ .Values.service.nodePort }} |
There was a problem hiding this comment.
same issue with host port as stun server. check if applicable elsewhere
There was a problem hiding this comment.
Added guards in each deployment template, updated helm README also.
metro-ai-suite/live-video-analysis/live-video-captioning/charts/values-override.yaml
Outdated
Show resolved
Hide resolved
…ctions for host port bindings
4 participants
Description
Helm chart updates for Live Video Captioning.
Any Newly Introduced Dependencies
N/A
How Has This Been Tested?
Tested to on local k8s setup
Checklist: