Conversation
Signed-off-by: Sudarshana Panda <sudarshana.panda@intel.com>
Signed-off-by: Sudarshana Panda <sudarshana.panda@intel.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Docker image scanning workflow by updating image names and tags to match the actual images being built and scanned.
- Updates environment variable configurations to use specific version tags instead of
latest - Corrects Docker image names to include the
intel/registry prefix for Trivy scanning commands - Ensures consistency between the images built and the images being scanned
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Sudarshana Panda <sudarshana.panda@intel.com>
vkb1
added
the
2025.2 Time Series Sample Apps
vkb1
left a comment
vkb1
left a comment
There was a problem hiding this comment.
Hi @SudarshanaPanda ,
Seems like you missed to notice that we were not added as reviewers, please cross check next time else we would never know if there has been any PR raised for us to review.
| sed -i -e "s|OPC_UA_SERVER_IMAGE=.*|OPC_UA_SERVER_IMAGE=ia-opcua-server:1.0.0-weekly|g" .env | ||
| sed -i -e "s|MQTT_PUBLISHER_IMAGE=.*|MQTT_PUBLISHER_IMAGE=ia-mqtt-publisher:1.1.0-weekly|g" .env |
There was a problem hiding this comment.
These lines are reduntant, can be removed.
| @@ -183,24 +183,26 @@ jobs: | |||
| echo "Building Wind Turbine Sample App and scanning Image" | |||
There was a problem hiding this comment.
Let's rename this as "Building Time Series sample apps and scanning images..."
| IMAGE_TO_SCAN1=${MQTT_PUBLISHER_IMAGE}${IMAGE_SUFFIX:+-${IMAGE_SUFFIX}} | ||
| IMAGE_TO_SCAN2=${OPC_UA_SERVER_IMAGE}${IMAGE_SUFFIX:+-${IMAGE_SUFFIX}} |
There was a problem hiding this comment.
We can have a loop to execute the below steps for above 2 entries, the above 2 entries can be kept simple as below:
OPCUA_IMAGE=${OPC_UA_SERVER_IMAGE}-${IMAGE_SUFFIX}
MQTT_PUB_IMAGE=${OPC_UA_SERVER_IMAGE}-${IMAGE_SUFFIX}
|
Closing as this PR is not required anymore. |
successful run: https://github.com/open-edge-platform/edge-ai-suites/actions/runs/18335901795