-
Notifications
You must be signed in to change notification settings - Fork 75
Add camera setup and integration documentation for RVC #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @axion9, i have reviewed the commit changes under PR and noticed some minor grammar and clarity issues. I have fixed it and created a PR to merge these changes into your fork branch. |
d85e49e to
f9192ae
Compare
Merged documentation clarity and grammar improvements. Thanks for the help!
|
@PremIntel thanks for the improvements, I accepted each and merged! |
Pirouf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kblaszczak-intel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs team is currently working on improving a set of articles in the robotics area. We will do a review of these articles once they are merged, so that we do not block further changes.
We will also port them to the release branch.
@kblaszczak-intel Quick question... I am going through the doc "line by line" and have found additional items that should be remediated. Should I submit changes for those, or wait until there is a doc overhaul? No worries either way, but I am finding additional items that could benefit from a fix. For example, the "Components of RVC / Vision" section is a bit confusing and dated. There are multiple examples within the 2.5D and Dynamic sections, but one is the "RealSense Node" depicted in the images doesn't appear to exist in the code. I believe this now maps to "rvc_vision_main", like this:
Again, no worries if I should just wait for a doc overhaul, but let me know. - Thanks |
|
I suggest we merge this one and then start fixing issues in another PR. This way all the goodness is published more rapidly. And we won't block Pirouf, I know he's also working on new content. And if you see more potential improvements, that's awesome! Let's merge this one and start fixing what we can :) I will be happy to help. And once the content is more or less fine, we'll go through the language, structure, we'll redraw diagrams so that they are vector-based and easily editable, etc. Does that sound acceptable? |

Description
This pull request updates the RVC documentation to improve clarity and guide new contributors through camera setup and integration. Key changes include:
Fixes # (issue)
NA
Any Newly Introduced Dependencies
No
How Has This Been Tested?
These changes were tested locally by building the documentation from a clean environment and verifying all links, images, and Sphinx builds complete without errors.
Checklist: