Delete finalizers to ensure resources are deleted#1213
Closed
palade wants to merge 15 commits intofix_upgrade_main_brfrom
Closed
Delete finalizers to ensure resources are deleted#1213palade wants to merge 15 commits intofix_upgrade_main_brfrom
palade wants to merge 15 commits intofix_upgrade_main_brfrom
Conversation
Co-authored-by: Andrei Palade <[email protected]>
palade
requested review from
Ram-srini,
SushilLakra,
cjnolan,
damiankopyto,
garyloug,
guptagunjan,
hyunsun,
johnoloughlin,
krishnajs,
rranjan3,
scottmbaker,
shankarsrinivas1,
soniabha-intc and
sys-orch-approve
as code owners
palade
force-pushed
the
add_finalizers
branch
from
b7465b8 to
eb18a42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds ensures that the finalizers are deleted before the resources are removed to not block upgrade script.
Fixes # (issue)
Any Newly Introduced Dependencies
n/a
How Has This Been Tested?
locally
Checklist: