Skip to content

Update gitea credential namespace #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update gitea credential namespace #285

wants to merge 8 commits into from

Conversation

palade
Copy link
Contributor

@palade palade commented May 8, 2025

Description

The argocd-gitea-credential is created under the orch-platform namespace, but on the onprem, this is created under gitea. This should be changed to gitea in the deploy target to match onprem.

Any Newly Introduced Dependencies

none.

How Has This Been Tested?

in the ci.

Checklist:

  • I agree to use the APACHE-2.0 license for my code changes
  • I have not introduced any 3rd party dependency changes
  • I have performed a self-review of my code

@palade palade self-assigned this May 8, 2025
@palade palade force-pushed the change_gitea_namespace branch from 4045691 to 4e4be20 Compare May 8, 2025 14:59
@palade palade changed the title DO NOT MERGE: Update gitea credential namespace Update gitea credential namespace May 8, 2025
charlesmcchan
charlesmcchan reviewed May 8, 2025
View reviewed changes
Copy link
Member

@charlesmcchan charlesmcchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use ClusterRole to grant permission to read secrets from another namespace to such job so we don't need to duplicate the secrets?

@ajaythakurintel ajaythakurintel added this to the 3.1 milestone May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesmcchan charlesmcchan charlesmcchan left review comments

@se-chris-thach se-chris-thach Awaiting requested review from se-chris-thach se-chris-thach is a code owner

@mdbalvin mdbalvin Awaiting requested review from mdbalvin mdbalvin is a code owner

@rad-szulim rad-szulim Awaiting requested review from rad-szulim

@yi-tseng-intel yi-tseng-intel Awaiting requested review from yi-tseng-intel

@ashridatta ashridatta Awaiting requested review from ashridatta ashridatta is a code owner

@teone teone Awaiting requested review from teone

@callumnobleintel callumnobleintel Awaiting requested review from callumnobleintel

@daniele-moro daniele-moro Awaiting requested review from daniele-moro

@SeanCondon SeanCondon Awaiting requested review from SeanCondon

@pierventre pierventre Awaiting requested review from pierventre

@cgoea cgoea Awaiting requested review from cgoea

@emmakenny emmakenny Awaiting requested review from emmakenny emmakenny is a code owner

@PalashGoelIntel PalashGoelIntel Awaiting requested review from PalashGoelIntel PalashGoelIntel is a code owner

@pperycz pperycz Awaiting requested review from pperycz

@ltalarcz ltalarcz Awaiting requested review from ltalarcz

@jakubsikorski jakubsikorski Awaiting requested review from jakubsikorski

@sys-orch-approve sys-orch-approve Awaiting requested review from sys-orch-approve sys-orch-approve is a code owner

@ahalimx86 ahalimx86 Awaiting requested review from ahalimx86

@johnoloughlin johnoloughlin Awaiting requested review from johnoloughlin johnoloughlin is a code owner

@garyloug garyloug Awaiting requested review from garyloug garyloug is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@palade palade

Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@palade @charlesmcchan @ajaythakurintel