Perm bound #824
Draft
Perm bound #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Goyal, Pankaj <[email protected]>
Signed-off-by: Goyal, Pankaj <[email protected]>
pankajgoyal2
requested review from
SushilLakra,
cjnolan,
damiankopyto,
garyloug,
guptagunjan,
hyunsun,
johnoloughlin,
krishnajs,
palade,
rranjan3,
scottmbaker,
soniabha-intc and
sys-orch-approve
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+78
to
+88
| resource "aws_kms_key" "vault" { | ||
| description = "Vault unseal key for ${var.cluster_name}" | ||
| deletion_window_in_days = 10 | ||
|
|
||
| tags = { | ||
| Name = "vault-kms-unseal-${var.cluster_name}" | ||
| Cluster = var.cluster_name | ||
| Purpose = "vault-unseal" | ||
| Application = "vault" | ||
| } | ||
| } |
Check warning
Code scanning / Trivy
A KMS key is not configured to auto-rotate. Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. List any dependencies that are required for this change.
Fixes # (issue)
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: